refactor(runtime-alerts): Re-home legacy alert package#1169
Merged
Conversation
Move the legacy user alert cluster and its package-local tests from network.crypta.node.useralerts into network.crypta.runtime.alerts, and relocate UserAlertManagerStoreAlertSink alongside them. Update main-source and test references, Javadocs, and SpotBugs exclusions to the new package, and add root-build stale-output pruning so non-clean builds stop packaging deleted node.useralerts classes into cryptad.jar.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network.crypta.node.useralertscluster intonetwork.crypta.runtime.alertsUserAlertManagerStoreAlertSinkalongside the alert cluster and update main/test references, Javadocs, and SpotBugs excludesnode.useralertsclasses intocryptad.jarHow to test
./gradlew compileJava compileTestJava./gradlew test --tests 'network.crypta.runtime.alerts.*' --tests 'network.crypta.node.PeerAlertCoordinatorTest' --tests 'network.crypta.node.subsystem.NodeServicesSubsystemTest' --tests 'network.crypta.node.subsystem.NodeStorageSubsystemTest' --tests 'network.crypta.runtime.endpoints.ClientEndpointsTest' --tests 'network.crypta.runtime.admin.LegacyWelcomeActionPortTest' --tests 'network.crypta.clients.http.UserAlertsToadletTest' --tests 'network.crypta.node.updater.NodeUpdateManagerTest' --tests 'network.crypta.node.updater.UpdateOverMandatoryManagerTest'./gradlew buildJarrg -n "network\\.crypta\\.node\\.useralerts|network\\.crypta\\.node\\.runtime\\.UserAlertManagerStoreAlertSink" .Notes
buildJarwas verified against a dirty incremental output state to confirm the legacy alert classes are pruned from bothbuild/classes/java/mainandbuild/libs/cryptad.jar.LongTermPushRepullTestTestis pre-existing and unrelated to this change.